Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(NcHeaderMenu): pass text-on-background color for header menu #5747

Merged
merged 1 commit into from
Jul 2, 2024
Merged

style(NcHeaderMenu): pass text-on-background color for header menu #5747

merged 1 commit into from
Jul 2, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Drop internal styles at server:
    • UnifiedSearch
    • ContactsMenu
    • AppMenu (NcActions aria-label="More apps")

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: header-menu labels Jun 29, 2024
@Antreesy Antreesy added this to the 8.13.1 milestone Jun 29, 2024
@Antreesy Antreesy requested a review from susnux June 29, 2024 07:50
@Antreesy Antreesy self-assigned this Jun 29, 2024
@Antreesy Antreesy force-pushed the fix/noid/header-menu-icons branch from f2a45b0 to d175fee Compare July 1, 2024 06:33
@Antreesy Antreesy mentioned this pull request Jul 1, 2024
Merged
1 task
@susnux susnux requested review from skjnldsv, Pytal and ShGKme July 1, 2024 09:16
@susnux susnux modified the milestones: 8.13.1, 8.14.0 Jul 1, 2024
@susnux
Copy link
Contributor

susnux commented Jul 1, 2024

/backport to next

@Antreesy Antreesy requested a review from DorraJaouad July 2, 2024 15:56
@Antreesy Antreesy merged commit 588fb04 into master Jul 2, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/noid/header-menu-icons branch July 2, 2024 16:08
@backportbot backportbot bot mentioned this pull request Jul 2, 2024
Merged
@nickvergessen
Copy link
Contributor

"More apps" … is still white? :D

@Antreesy
Copy link
Contributor Author

Antreesy commented Jul 3, 2024

is still white?

Should be fixed in server repo, as I see it

@Antreesy Antreesy mentioned this pull request Jul 3, 2024
Closed
8 tasks
@susnux susnux mentioned this pull request Jul 4, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: header-menu
Projects
None yet
Milestone
8.14.0
Development

Successfully merging this pull request may close these issues.

notification bell does not adapt to theme, always white
4 participants
@Antreesy @susnux @nickvergessen @DorraJaouad